{"id":70,"date":"2016-08-17T09:25:00","date_gmt":"2016-08-17T07:25:00","guid":{"rendered":"https:\/\/blogs.scummvm.org\/blorente\/?p=70"},"modified":"2022-04-15T13:14:36","modified_gmt":"2022-04-15T11:14:36","slug":"final-sprint-submitting-the-pr","status":"publish","type":"post","link":"https:\/\/blogs.scummvm.org\/blorente\/2016\/08\/17\/final-sprint-submitting-the-pr\/","title":{"rendered":"Final sprint: Submitting the PR"},"content":{"rendered":"\n<p>I am sorry for not writing in a while, but as the finish date for GSoC comes closer, everything has to be ready for the end. My mentor and I agreed that the PR sould be submitted around August 14th, so these last days my intention was to have as much functionality as possible in before the PR came, as I was sure that after that I would have to spend all the time I had fixing things that I either forgot or didn\u2019t know were broken in the first place.<\/p>\n\n\n\n<!--more-->\n\n\n\n<p>I am sorry for not writing in a while, but as the finish date for GSoC comes closer, everything has to be ready for the end. My mentor and I agreed that the PR sould be submitted around August 14th, so these last days my intention was to have as much functionality as possible in before the PR came, as I was sure that after that I would have to spend all the time I had fixing things that I either forgot or didn\u2019t know were broken in the first place.<\/p>\n\n\n\n<p>However, I didn\u2019t get to implement much, since a pesky error on my part had me using valgrind for three days, looking for the source of a heap corruption. Luckily I found it and fixed it right in time, and the engine was in at least a playable (albeit not complete) when the PR happened.<\/p>\n\n\n\n<p>On the morning of the 15th I submitted the PR, and by now I have received tons of excellent feedback, and have compiled a <a href=\"https:\/\/web.archive.org\/web\/20200426204825\/https:\/\/t.umblr.com\/redirect?z=https%3A%2F%2Ftrello.com%2Fb%2FUOfhgSHj%2Fgsoc16&amp;t=ZDRiYTQzYjY1NGE1YzkxMTYwMjJjY2VjNTg3ZTcwY2RlYjg4MDVmNixuaGdXU2hzYg%3D%3D&amp;b=t%3A1B-6m0r5fRzyZAKM79LNMg&amp;p=https%3A%2F%2Fblorente.tumblr.com%2Fpost%2F149072598767%2Ffinal-sprint-submitting-the-pr&amp;m=1\" target=\"_blank\" rel=\"noreferrer noopener\">list of fixes<\/a> that need to happen. Thanks to everybody for pointing these things out that fast, so I can get to work right away \ud83d\ude42&nbsp;<\/p>\n\n\n\n<p>On a side note, I am planning on writing a postmortem once the GSoC is done, with some important lessons I learned during this experience, which will hopefuly be of some use to future me and anybody that comes after.<\/p>\n\n\n\n<p>For the rest of GSoC I\u2019ll be working on the PR, which you can check out<a href=\"https:\/\/web.archive.org\/web\/20200426204825\/https:\/\/t.umblr.com\/redirect?z=https%3A%2F%2Fgithub.com%2Fscummvm%2Fscummvm%2Fpull%2F807&amp;t=MGUyMzNkYzc2YTU0OGQzOTIzMTNmN2RjY2NmZjQxYmU2YTZkOThiYyxuaGdXU2hzYg%3D%3D&amp;b=t%3A1B-6m0r5fRzyZAKM79LNMg&amp;p=https%3A%2F%2Fblorente.tumblr.com%2Fpost%2F149072598767%2Ffinal-sprint-submitting-the-pr&amp;m=1\" target=\"_blank\" rel=\"noreferrer noopener\"> here<\/a>. Please feel free to pull and test it, I\u2019d be very thankful for any feedback to make the project as good as it can be.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>I am sorry for not writing in a while, but as the finish date for GSoC comes closer, everything has to be ready for the end. My mentor and I agreed that the PR sould be submitted around August 14th, so these last days my intention was to have as much functionality as possible in [&hellip;]<\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"class_list":["post-70","post","type-post","status-publish","format-standard","hentry","category-uncategorized"],"_links":{"self":[{"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/posts\/70","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/comments?post=70"}],"version-history":[{"count":1,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/posts\/70\/revisions"}],"predecessor-version":[{"id":71,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/posts\/70\/revisions\/71"}],"wp:attachment":[{"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/media?parent=70"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/categories?post=70"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.scummvm.org\/blorente\/wp-json\/wp\/v2\/tags?post=70"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}