Notify the engine that the sound settings in the config manager might have changed and that it should adjust any internal volume (and other) values accordingly.<\/p>ScummVM Doxygen<\/cite><\/blockquote>\n\n\n\nTherefore we call it once in the Music<\/code> constructor to initialize its values accordingly to the config manager.<\/p>\n\n\n\n- Music does not cut out at zero<\/li><\/ul>\n\n\n\n
How it was fixed:<\/p>\n\n\n\n
inline int16 quantizedVolume(uint16 trueVolume) {\n\tint16 quantized = trueVolume & 0xFFF8;\n\tquantized += (quantized \/ 16);\n\n\n---\tquantized += 2; \/\/ In ScummVM the range is 0..255\n+++\tquantized = CLIP(quantized, (int16)0, (int16)255);\n\n\treturn quantized;\n}<\/code><\/pre>\n\n\n\nHere quantized<\/code> is the value used for the config manager, which is 0-255 for ScummVM. Thankfully quantized already goes from 0-255 (except when fully maxed, at which point it slightly caps over 255, which is why we clip it).<\/p>\n\n\n\nDocument Issues<\/h2>\n\n\n\n- Arrow sprites not changing<\/li><\/ul>\n\n\n\n
\n\/\/ Sets the mouse pointer imagery\nvoid gMousePointer::setImage(\n gPixelMap &img,\n int x,\n int y) {\n\tPoint16 pos = currentPosition - offsetPosition;\n\n\tif (pointerImage != &img\n\t || x != offsetPosition.x\n\t || y != offsetPosition.y\n\t || img.size != saveMap.size) {\n\t\toffsetPosition.x = x;\n\t\toffsetPosition.y = y;\n ...\n }\n...\n}<\/code><\/pre>\n\n\n\nWhen changing the pointer image (done with gMousePointer::setImage<\/code>) we check whether the img<\/code> pointer changed. However in mouseimg.cpp<\/code> where we call setImage<\/code>,<\/p>\n\n\n\ncreateStackedImage(combinedImage, &combinedImageCenter, imageArray, imageCenterArray, imageIndex);\n\nimageOffset.x = combinedImageCenter - mouseImage->size.x \/ 2;\nimageOffset.y = 0;\n\n\/\/ Set the combined image as the new mouse cursor\ng_vm->_pointer->hide();\ng_vm->_pointer->setImage(combinedImage, mouseImageOffset.x - imageOffset.x, mouseImageOffset.y - imageOffset.y);\ng_vm->_pointer->show();<\/code><\/pre>\n\n\n\ncombinedImage<\/code> never actually changes value. Therefore we change createStackedImage<\/code> to modify combined combinedImage<\/code> everytime it is called:<\/p>\n\n\n\nvoid createStackedImage(gPixelMap **newImage, int *newImageCenter, gPixelMap **imageArray, int *imageCenterArray, int images) {\n\tassert(images != 0);\n\n\tif (*newImage)\n\t\tdelete *newImage;\n\n\t*newImage = new gPixelMap;\n...\n}<\/code><\/pre>\n\n\n\nOf course, we modify the usage in the rest of code for this.<\/p>\n\n\n\n
- Close parchment button not working<\/li><\/ul>\n\n\n\n
The cause for this was a typo. Oops.<\/p>\n\n\n\n
CDocumentAppearance parchAppearance = {\n\t{202, 54, 208, 256},\n\t1,\n\tpageOrientVertical,\n\tbookTextColors,\n\t{ {27, 18, 149, 212}, {0, 0, 0, 0} },\n--\t{64, 229, 20, 20},\n++\t{164, 229, 20, 20},\n\tparchDecorations,\n\tARRAYSIZE(parchDecorations),\n\tMKTAG('P', 'A', 'R', 'C'),\n\tMKTAG('P', 'C', 'H', 0)\n};<\/code><\/pre>\n\n\n\n- Crash on reading Kaidar’s book<\/li><\/ul>\n\n\n\n
The cause for this was a unsigned to signed conversion. Therefore, we make a cast to uint16<\/code>.<\/p>\n\n\n\nuint8 *Thread::strAddress(int strNum) {\n\tuint16 seg = READ_LE_INT16(codeSeg + 2);\n\tuint16 offset = READ_LE_INT16(codeSeg + 4);\n\tuint8 *strSeg = segmentAddress(seg, offset);\n\n\tassert(strNum >= 0);\n\tassert(codeSeg);\n\tassert(strSeg);\n\n---\treturn strSeg + READ_LE_INT16(strSeg + 2 * strNum);\n+++\treturn strSeg + (uint16)READ_LE_INT16(strSeg + 2 * strNum);\n}<\/code><\/pre>\n\n\n\n- Crash on Credits<\/li><\/ul>\n\n\n\n
The cause for this was a strcat overlap. How did this work in the original, even?<\/em><\/p>\n\n\n\nbool CDocument::checkForPageBreak(char *string, uint16 index, int32 &offset) {\n\n\t\/\/ get the current index into the string\n\tchar *strIndex = string + index;\n+++\tchar *strAfter;\n\n\t\/\/ page break detected\n\tif (strIndex[1] == dPageBreak[0] &&\n\t strIndex[2] == dPageBreak[1]) {\n\t\t\/\/ eat the page breaks chars\n\t\t\/\/ tie off the end\n\t\tstrIndex[0] = 0;\n+++\t\tstrAfter = new char[textSize];\n+++\t\tCommon::strlcpy(strAfter, &strIndex[3], textSize);\n\n\t\t\/\/ string them together\n---\t\tstrcat(&strIndex[0], &strIndex[2 + 1]);\n+++\t\tstrcat(&strIndex[0], strAfter);\n\n\t\t\/\/ take the offset to the end of this line\n\t\toffset = index;\n\n\t\t\/\/ and set the new page flag\n\n+++\t\tdelete[] strAfter;\n\t\treturn true;\n\t}\n\n\treturn false;\n}<\/code><\/pre>\n\n\n\nKeyboard<\/h2>\n\n\n\n
We change the original game’s scheme of key recognition to the one found in common\/keyboard.h<\/code>. Therefore we change things like SpecialKey(upArrowKey)<\/code> to Common::KEYCODE_UP<\/code>.<\/p>\n\n\n\nswitch (key) {\ncase Common::KEYCODE_UP:\n\tselectionUp(1);\n\treturn true;\n\ncase Common::KEYCODE_DOWN:\n\tselectionDown(1);\n\treturn true;\n\ncase Common::KEYCODE_PAGEUP:\n\tselectionUp(linesPerPage);\n\treturn true;\n\ncase Common::KEYCODE_PAGEDOWN:\n\tselectionDown(linesPerPage);\n\treturn true;\n}<\/code><\/pre>\n\n\n\n
\n\n\n\nA few weeks left until GSoC ends, while summer break is about to start here. Let’s do our best.<\/p>\n","protected":false},"excerpt":{"rendered":"
Time for the weekly progress report! This week I have finals, so studies had to be prioritized, but here is what has progressed since the last report: Bugs Here are the newly identified bugs: Bug Steps to reproduce Explanation Solved The first track played when the game start is random When running in DOSBox, it […]<\/p>\n","protected":false},"author":7,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"class_list":["post-62","post","type-post","status-publish","format-standard","hentry","category-uncategorized"],"_links":{"self":[{"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/posts\/62","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/users\/7"}],"replies":[{"embeddable":true,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/comments?post=62"}],"version-history":[{"count":2,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/posts\/62\/revisions"}],"predecessor-version":[{"id":65,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/posts\/62\/revisions\/65"}],"wp:attachment":[{"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/media?parent=62"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/categories?post=62"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/blogs.scummvm.org\/ayyg\/wp-json\/wp\/v2\/tags?post=62"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}